[Mageia-dev] [packages-commits] [329082] - mod_siren is not optional

D.Morgan dmorganec at gmail.com
Sun Dec 9 18:47:53 CET 2012


On Sun, Dec 9, 2012 at 5:21 PM,  <root at mageia.org> wrote:
> Revision 329082 Author dlucio Date 2012-12-09 17:21:44 +0100 (Sun, 09 Dec
> 2012)
>
> Log Message
>
> - mod_siren is not optional
> - mod_spidermonkey is disabled
>
> Modified Paths
>
> cauldron/freeswitch/current/SPECS/freeswitch.spec
>
> Modified: cauldron/freeswitch/current/SPECS/freeswitch.spec
> ===================================================================
> --- cauldron/freeswitch/current/SPECS/freeswitch.spec	2012-12-09 15:59:02
> UTC (rev 329081)
> +++ cauldron/freeswitch/current/SPECS/freeswitch.spec	2012-12-09 16:21:44
> UTC (rev 329082)
> @@ -1,3 +1,4 @@
> +%define	Werror_cflags -Wformat
>  %define _disable_ld_as_needed 1
>  %define _disable_ld_no_undefined 1
>  %define _disable_ld_relro 1
> @@ -5,6 +6,34 @@
>  %define _disable_ld_build_id 1
>  %define _disable_ld_enable_new_dtags 1
>  %define _disable_libtoolize 1
> +######################################################################################################################
> +#
> +# spec file for package freeswitch
> +#
> +# includes module(s): freeswitch-devel freeswitch-codec-passthru-amr
> freeswitch-codec-passthru-amrwb freeswitch-codec-passthru-g729
> +#                     freeswitch-codec-passthru-g7231 freeswitch-lua
> freeswitch-perl freeswitch-python
> +#                     freeswitch-lan-de freeswitch-lang-en
> freeswitch-lang-fr freeswitch-lang-hu freeswitch-lang-ru freeswitch-freetdm
> +#
> +# Initial Version Copyright (C) 2007 Peter Nixon and Michal Bielicki, All
> Rights Reserved.
> +#
> +# This file is part of:
> +# FreeSWITCH Modular Media Switching Software Library / Soft-Switch
> Application
> +# Copyright (C) 2005-2012, Anthony Minessale II <anthm at freeswitch.org>
> +#
> +# This file and all modifications and additions to the pristine package are
> under the same license as the package itself.
> +#
> +# Contributor(s): Mike Jerris
> +#                 Brian West
> +#                 Anthony Minessale II <anthm at freeswitch.org>
> +#                 Raul Fragoso
> +#                 Rupa Shomaker
> +#                 Marc Olivier Chouinard
> +#                 Raymond Chandler
> +#                 Ken Rice <krice at freeswitch.org>
> +#
> +# Maintainer(s): Ken Rice <krice at freeswitch.org>
> +#


so you get rid of all cleaning done by other people without notifying
in the commit log . Please propedit your specfile.

And in addition as told this would be better to review the spec file
before submiting because it is just horrible and would need some more
work/love... but you already submited, Hopefully you removed libnspr4
but too WITHOUT notification.

you still have ;


%{LIBDIR}/libfreeswitch*.so*
%{LIBDIR}/libfreeswitch*.a

in the main package which is against all our policies and you still
use %{LIBDIR} instead of %{_libdir} ( means you reverted my cleaning
without notify it in the commit log ( not really fair )

Please fix and/or ask for help because we need quality in mageia.

Regards,
D.


More information about the Mageia-dev mailing list