[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.

[Angelo Naselli]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thanks Guillaume
to have started reviewing the code :)

As said I'm not a perl developer, so any help
change and what else is appreciated.

Now all is in our svn, so I, well we all, do hope
in increasing contribution to make our little toy
a real product.

I won't comment perl adjustment since i just cut&paste
some code to get my things running i'm leaving this
aim to who in the group is more perl active :)

>> +#    Copyright 2012 Matteo Pasotti +# +#    This file is part of
>> mcc2 +# +#    mcc2 is free software: you can redistribute it
>> and/or modify +#    it under the terms of the GNU General Public
>> License as published by +#    the Free Software Foundation,
>> either version 2 of the License, or +#    (at your option) any
>> later version. +# +#    mcc2 is distributed in the hope that it
>> will be useful, +#    but WITHOUT ANY WARRANTY; without even the
>> implied warranty of +#    MERCHANTABILITY or FITNESS FOR A
>> PARTICULAR PURPOSE.  See the +#    GNU General Public License for
>> more details. +# +#    You should have received a copy of the GNU
>> General Public License +#    along with mcc2.  If not, see
>> <http://www.gnu.org/licenses/>.
> I'm not convinced of the interest of repeating license and
> copyright information in every single file, whereas a single
> top-level README file would be enough.
Well isn't it required by gnu and common way of using gpl in
programming?
But perhaps i see your point the bigger is a scripting file the
more disk space is using.

> I'm convinced tough than using a shared top-level namespace, for 
> instance AdminPanel or Mageia::AdminPanel, would be a better idea
> to express the idea than this module is a part of a software, than
> a loose comment such as "This file is part of mcc2". package
> Mageia::AdminPanel::Auth;
Using a namespace could be a good idea, as said this is a simple toy
at the moment. I'm not sure using Mageia though is right as well,
it's been thought as a general purpose admin panel at the moment...

> BTW, your indentation isn't consistent between various files.
well, ehm I think it's my fault, i use kde editor and i don't like
tab. Is there any policy for that? I mean tab=8, tab as a tab and not
space etc? Or we can use ours one and for all?

Cheers,
	Angelo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlCZJLYACgkQqEs9DA4DquDTCACfc1o+7lu/SwfXuMWn51MtSt4X
u5UAnRehfRZUAkF94g03OirhxYsWMfC6
=wo6L
-----END PGP SIGNATURE-----