[Mageia-dev] [soft-commits] [6435] Added a first log viewer module.

[Guillaume Rousse]

Le 11/11/2012 19:13, root at mageia.org a écrit :
> +package LogViewer;
> +
> +use strict;
> +use POSIX;
never load the POSIX module this way. Either import it without importing 
any symbol in your namespace, either import just the symbols you need. 
See POSIX(3pm) for details.

[..]
> +    $::isWizard = 1;
ugly syntax.

[..]
> +#- check services
> +my ) . Data::Dumper->Dump([ $service ], [qw(*services)]) . q(
> +foreach (split(':', $options{SERVICES})) {
> +    next unless $services{$_};
> +    $r .= "Service $_ ($services{$_} is not running)\\n" unless -e "/var/lock/subsys/$_";
> +}
You shouldn't leave debugging statement in your code. Moreover, I doubt 
this is syntactically correct. Do you use Test::Compile to check your 
code compiles correctly ?

-- 
BOFH excuse #208:

Your mail is being routed through Germany ... and they're censoring us.