[Mageia-dev] [soft-commits] [5686] For non-local media, iurt is suppressing the urpmi. cfg file while creating

[Colin Guthrie]

'Twas brillig, and Thierry Vignaud at 06/09/12 09:08 did gyre and gimble:
> +++ b/lib/Iurt/Chroot.pm
> @@ -300,23 +300,11 @@ sub check_chroot_need_update {
>  
>  sub create_build_chroot {
>      my ($chroot, $chroot_ref, $run, $config) = @_;
> -    my $ret = 0;
>      if ($run->{storage} eq 'btrfs') {
> -        $ret = create_build_chroot_btrfs($chroot, $chroot_ref, $run, $config);
> +        return create_build_chroot_btrfs($chroot, $chroot_ref, $run, $config);
>      } else {
> -        $ret = create_build_chroot_tar($chroot, $chroot_ref, $run, $config);
> +        return create_build_chroot_tar($chroot, $chroot_ref, $run, $config);
>      }


Not sure if it fits your own coding style, but I would leave the "else"
out here as it's redundant.

Col

-- 

Colin Guthrie
colin(at)mageia.org
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/