[Mageia-sysadm]  - it is IMHO cleaner and logical to have apache:: vhost_other_app directly requiring apache:: base rather than letting every people adding it when using the class
misc at zarb.org
Tue Nov 23 16:55:18 CET 2010
Le mardi 23 novembre 2010 à 08:09 +0100, Olivier Blin a écrit :
> root at mageia.org writes:
> > Revision: 412
> > Author: misc
> > Date: 2010-11-23 02:14:05 +0100 (Tue, 23 Nov 2010)
> > Log Message:
> > -----------
> > - it is IMHO cleaner and logical to have apache::vhost_other_app
> > directly requiring apache::base rather than letting every people
> > adding it when using the class
> Yep, but shouldn't we still "include apache" in the buildsystem module?
No. The apache class is just a container for other class.
I am not sure of what would happen if we do include it. Likely nothing
( as the class is empty ).
> I took example from modules/bugzilla, which has a vhost_other_app as
> well, but this one has an "include apache::mod_fcgid", while it does not
> use mod_fcgid directly...
> Should be fixed as well
Indeed, I didn't catch it.
More information about the Mageia-sysadm