[Mageia-sysadm] [279] add missing parentheses in open calls

[root at mageia.org]

Revision: 279
Author:   blino
Date:     2011-01-13 13:42:41 +0100 (Thu, 13 Jan 2011)
Log Message:
-----------
add missing parentheses in open calls

Modified Paths:
--------------
    build_system/iurt/trunk/lib/Iurt/Chroot.pm
    build_system/iurt/trunk/lib/Iurt/DKMS.pm
    build_system/iurt/trunk/lib/Iurt/Process.pm
    build_system/iurt/trunk/lib/Iurt/Urpmi.pm

Modified: build_system/iurt/trunk/lib/Iurt/Chroot.pm
===================================================================
--- build_system/iurt/trunk/lib/Iurt/Chroot.pm	2011-01-13 12:40:21 UTC (rev 278)
+++ build_system/iurt/trunk/lib/Iurt/Chroot.pm	2011-01-13 12:42:41 UTC (rev 279)
@@ -287,7 +287,7 @@
     plog('DEBUG', "... dir $dir all $run->{clean_all} prefix $prefix");
 
     if ($run->{clean_all}) {
-	opendir my $chroot_dir, $dir;
+	opendir(my $chroot_dir, $dir);
 	foreach (readdir $chroot_dir) {
 	    next if !-d "$dir/$_" || /\.{1,2}/;
 	    plog("cleaning old chroot for $_ in $dir");

Modified: build_system/iurt/trunk/lib/Iurt/DKMS.pm
===================================================================
--- build_system/iurt/trunk/lib/Iurt/DKMS.pm	2011-01-13 12:40:21 UTC (rev 278)
+++ build_system/iurt/trunk/lib/Iurt/DKMS.pm	2011-01-13 12:42:41 UTC (rev 279)
@@ -67,7 +67,7 @@
 	my $media_ok = $run->{dkms}{media} ? $media =~ /$run->{dkms}{media}/ : 1;
 	my $kmedia_ok = $run->{dkms}{kmedia} ? $media =~ /$run->{dkms}{kmedia}/ : 1;
 	plog("searching in $path");
-	opendir my $rpmdh, $path;
+	opendir(my $rpmdh, $path);
 	foreach my $rpm (readdir $rpmdh) {
 	    if ($rpm =~ /^dkms-(.*)-([^-]+-[^-]+)\.[^.]+\.rpm/) {
 		# we only check for kernel or modules in this media

Modified: build_system/iurt/trunk/lib/Iurt/Process.pm
===================================================================
--- build_system/iurt/trunk/lib/Iurt/Process.pm	2011-01-13 12:40:21 UTC (rev 278)
+++ build_system/iurt/trunk/lib/Iurt/Process.pm	2011-01-13 12:42:41 UTC (rev 279)
@@ -44,7 +44,7 @@
     if (-f $pidfile)  {
 	my (@stat) = stat $pidfile;
 
-	open my $test_PID, $pidfile;
+	open(my $test_PID, $pidfile);
 	my $pid = <$test_PID>;
 	close $test_PID;
 

Modified: build_system/iurt/trunk/lib/Iurt/Urpmi.pm
===================================================================
--- build_system/iurt/trunk/lib/Iurt/Urpmi.pm	2011-01-13 12:40:21 UTC (rev 278)
+++ build_system/iurt/trunk/lib/Iurt/Urpmi.pm	2011-01-13 12:42:41 UTC (rev 279)
@@ -157,7 +157,7 @@
 
 	if (-d $local_media) {
 	    mkdir("$chroot_tmp/iurt_media/");
-	    opendir my $dir, $local_media;
+	    opendir(my $dir, $local_media);
 	    my $next;
 	    foreach my $f (readdir $dir) {
 		$f =~ /(\.rpm|^hdlist.cz)$/ or next;
@@ -268,7 +268,7 @@
     my $program_name = $run->{program_name};
     my $local_media = $self->{local_media};
 
-    opendir my $dir, $local_media;
+    opendir(my $dir, $local_media);
     plog(1, "get local provides ($local_media)");
     require URPM;
     my $urpm = new URPM;
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/mageia-sysadm/attachments/20110113/84da35a8/attachment-0001.html>