[Mageia-sysadm] Youri Check

[Michael Scherer]

Le mardi 15 mars 2011 à 22:29 +0000, Pascal Terjan a écrit :
> I started running youri-check on rabbit and created an initial
> (untested) puppet module
> I attached the patch and welcome any comments

The module look good, I just have some questions.

Index: modules/youri-check/manifests/init.pp
===================================================================
--- modules/youri-check/manifests/init.pp       (revision 0)
+++ modules/youri-check/manifests/init.pp       (revision 0)
@@ -0,0 +1,30 @@
+class youri_check {

I think the class should be called youri-check, or the file in
youri_check ( iirc, not sure if this is a problem ). 

+    $user = 'youri'
+    $home = '/var/tmp/youri'
+    $outdir = "$home/www"
+    $config = "$home/check.conf"

Why not in /etc ?

Index: modules/youri-check/templates/check.conf
===================================================================
--- modules/youri-check/templates/check.conf    (revision 0)
+++ modules/youri-check/templates/check.conf    (revision 0)
@@ -0,0 +1,85 @@
+# vim:ft=yaml:et:sw=4
+
+# helper variables
+mirror: /distrib/mageia/distrib/cauldron
+mirror_i586: ${mirror}/i586/media
+mirror_x86_64: ${mirror}/x86_64/media
+
+# resultset definition
+resultset:
+    class: Youri::Check::Resultset::DBI
+    options:
+        driver: SQLite
+        host: localhost
+        base: youri.db

Where will it be exactly  ? in $HOME ?


+# media definitions
+medias:
+    core.i586:
+        class: Youri::Media::URPM
+        options:
+            name: core
+            type: binary
+            path: ${mirror_i586}/core
+            hdlist: ${mirror_i586}/media_info/hdlist_core.cz
+            options:
+                dependencies:
+                    allowed:
+                        - core.i586
+                missing:
+                    allowed:
+                        - core.sources

I guess the other directory will be added later ?

-- 
Michael Scherer