[Mageia-dev] [126688] - 0.94

[Ahmad Samir]

On 19 July 2011 21:12,  <root at mageia.org> wrote:
> Revision 126688 Author cjw Date 2011-07-19 21:12:55 +0200 (Tue, 19 Jul 2011)
>
> Log Message
>
> - 0.94
>
> Modified Paths
>
> cauldron/dbus-glib/current/SPECS/dbus-glib.spec
>
> Modified: cauldron/dbus-glib/current/SPECS/dbus-glib.spec
> ===================================================================
> --- cauldron/dbus-glib/current/SPECS/dbus-glib.spec	2011-07-19 19:12:47 UTC
> (rev 126687)
> +++ cauldron/dbus-glib/current/SPECS/dbus-glib.spec	2011-07-19 19:12:55 UTC
> (rev 126688)
> @@ -1,13 +1,6 @@
> -#if %mandriva_branch == Cooker
> -# Cooker
> -%define release %mkrel 2
> -#%else
> -# Old distros
> -#define subrel 2
> -#define release %mkrel 1
> -#endif
> -%define glib2_version           2.6.0
> -%define dbus_version		0.94
> +%define release %mkrel 1
> +%define glib2_version           2.26.0
> +%define dbus_version		1.2.16
>
>  %define lib_major 2
>  %define lib_api 1
> @@ -18,13 +11,12 @@
>
>  Summary: D-Bus message bus
>  Name: dbus-glib
> -Version: 0.88
> +Version: 0.94
>  Release: %release
>  URL: http://www.freedesktop.org/Software/dbus
>  Source0:
> http://dbus.freedesktop.org/releases/%name/%{name}-%{version}.tar.gz
>  License: AFL and GPLv2
>  Group: System/Libraries
> -BuildRoot: %{_tmppath}/%{name}-%{version}-root
>  BuildRequires: glib2-devel >= %{glib2_version}
>  BuildRequires: dbus-devel >= %{dbus_version}
>  BuildRequires: libxml2-devel
> @@ -63,7 +55,7 @@
>  %setup -q
>
>  %build
> -
> +autoreconf -fi

Hello,

The issue or running autoreconf in spec files is still unresolved, either:
- We only run it when needed (i.e. a patch that modifies configure.ac,
Makefile.{am,in}, building with a newer/older libtool) OR
- We run it in all the specs of packages that use libtool

Right now in most specs we only run it when needed, except some specs
you modified (like this one).

I am not with or against (don't have enough knowledge about libtool),
just pointing out that if autoreconf should be run for all packages
using libtool, then the policy should be clarified and applied to all
specs.

>  %configure2_5x  \
>      --disable-tests \
>      --disable-verbose-mode \
> @@ -99,9 +91,9 @@
>  %{_libdir}/pkgconfig/dbus-glib-%{lib_api}.pc
>  %{_includedir}/dbus-1.0/dbus/dbus-glib-bindings.h
>  %{_includedir}/dbus-1.0/dbus/dbus-gtype-specialized.h
> -%{_includedir}/dbus-1.0/dbus/dbus-glib-error-enum.h
>  %{_includedir}/dbus-1.0/dbus/dbus-glib-lowlevel.h
>  %{_includedir}/dbus-1.0/dbus/dbus-glib.h
> +%{_includedir}/dbus-1.0/dbus/dbus-gvalue-parse-variant.h
>  %{_datadir}/gtk-doc/html/dbus-glib/
>  %{_mandir}/man1/*
>
>
>



-- 
Ahmad Samir