[Mageia-dev] [soft-commits] [2376] fix medium variant test, check spent time testing

[Thierry Vignaud]

On 11 December 2011 16:52,  <root at mageia.org> wrote:
> Revision 2376 Author rda Date 2011-12-11 16:52:44 +0100 (Sun, 11 Dec 2011)
>
> Log Message
>
> fix medium variant test, check spent time testing
>
> -if ($info{medium} eq "DVD") {
> +if ($info{variant} =~ m/^LiveCD/) {

you don't need to use 'm' here since you didn't alter
the default separator ("/")

> +    # TODO: LiveCD specific tests
> +} else {
>      $harness->runtests(glob_('t_install_iso/*.t'));
> -} elsif ($info{medium} eq "CD") {
> -    # LiveCD specific
> -    # CD specific
>  }
>
>  # Umounting the ISO
>  print "# Umounting ISO\n";
> -# FIXME this fails sometimes; no idea why. Force umount?
> +# FIXME this fails sometimes (with LiveCDs); no idea why. Force umount?
>  system 'umount /media/iso_check';

then you should check with "lsof /media/iso_check" which
process are busying this mount point and report them back
Running "umount -l  /media/iso_check" will forcly umount

>  system 'rm -r /media/iso_check';

rm -r a directory? => rmdir

>  print "... ok\n";

you seems to print this whatever is the actual result of the tests.