[Mageia-dev] [115573] SILENT: new file ./SOURCES/gnome-video-effects-0.3. 0-fix-noarch-build.patch

[Christiaan Welvaart]

hi,

On Wed, 29 Jun 2011, root at mageia.org wrote:

> Revision: 115573
> Author:   wally
> Date:     2011-06-29 07:17:59 +0200 (Wed, 29 Jun 2011)
> Log Message:
> -----------
> SILENT: new file ./SOURCES/gnome-video-effects-0.3.0-fix-noarch-build.patch
>
> Added Paths:
> -----------
>    cauldron/gnome-video-effects/current/SOURCES/gnome-video-effects-0.3.0-fix-noarch-build.patch
>
> Added: cauldron/gnome-video-effects/current/SOURCES/gnome-video-effects-0.3.0-fix-noarch-build.patch
> ===================================================================
> --- cauldron/gnome-video-effects/current/SOURCES/gnome-video-effects-0.3.0-fix-noarch-build.patch	                        (rev 0)
> +++ cauldron/gnome-video-effects/current/SOURCES/gnome-video-effects-0.3.0-fix-noarch-build.patch	2011-06-29 05:17:59 UTC (rev 115573)
> @@ -0,0 +1,23 @@
> +--- ./config.sub.archfix	2008-04-01 19:46:41.000000000 +0200
> ++++ ./config.sub	2011-04-28 16:43:03.000000000 +0200
> +@@ -352,7 +352,7 @@ case $basic_machine in
> + 	| mt-* \
> + 	| msp430-* \
> + 	| nios-* | nios2-* \
> +-	| none-* | np1-* | ns16k-* | ns32k-* \
> ++	| noarch-* | none-* | np1-* | ns16k-* | ns32k-* \
> + 	| orion-* \
> + 	| pdp10-* | pdp11-* | pj-* | pjl-* | pn-* | power-* \
> + 	| powerpc-* | powerpc64-* | powerpc64le-* | powerpcle-* | ppcbe-* \
> +@@ -768,6 +768,9 @@ case $basic_machine in
> + 		basic_machine=i960-intel
> + 		os=-nindy
> + 		;;
> ++	noarch)
> ++		basic_machine=noarch
> ++		;;
> + 	mon960)
> + 		basic_machine=i960-intel
> + 		os=-mon960
> +
> +

You patched a copy of a standard automake file here while only original 
source files are supposed to be patched. If you want to fix %configure for 
noarch packages this way, patch automake itself. Running autoreconf -fi 
(which you removed from the specfile) should then install the fixed 
config.sub.

I'm not sure if patching config.sub is the best way to solve the problem 
(for noarch packages, %configure2_5x passes noarch-mageia-linux-gnu to 
./configure but that target is rejected). It happens in other packages as 
well and this doesn't look like a new problem, but I don't know of any 
existing solution.


     Christiaan