[Mageia-dev] Re : Re : Re : Re : E17 packaging

[Florian Hubold]

Am 23.10.2011 19:54, schrieb D.Morgan:
> On Sun, Oct 23, 2011 at 6:16 PM, Philippe Reynes<tremyfr at yahoo.fr>  wrote:
>> Hi,
>> I've updated (yes, yet another time ...) the eina.spec :
>> Index: eina/SPECS/eina.spec
>> ===================================================================
>> --- eina/SPECS/eina.spec        (révision 157379)
>> +++ eina/SPECS/eina.spec        (copie de travail)
>> @@ -1,18 +1,32 @@
>>   %define major 1
>>   %define libname %mklibname %{name} %major
>>   %define libnamedev %mklibname %{name} -d
>> +%define svn r64327
>> +%define rel 1
>> +%if %svn
>> +%define release %mkrel -c %svn %rel
>> +%else
>> +%define release %mkrel %rel
>> +%endif
>>
>>   Summary: Data Type Library
>>   Name: eina
>> -Version: 1.0.1
>> -Release: %mkrel 2
>> +Version: 1.0.999
>> +Release: %{release}
>>   License: LGPLv2+
>>   Group: Graphical desktop/Enlightenment
>> -Source:
>> http://download.enlightenment.org/releases/%{name}-%{version}.tar.bz2
>> -URL: http://www.enlightenment.org/
>> +# creating archive is quite simple:
>> +# svn export http://svn.enlightenment.org/svn/e/trunk/%name %name
>> +# tar cJf %name-%svn.tar.xz %name
>> +%if %svn
>> +Source: %name-%svn.tar.xz
>> +%else
>> +Source: http://download.enlightenment.org/releases/%name-%version.tar.bz2
>> +%endif
>> +URL: http://trac.enlightenment.org/e/wiki/Eina
>>   %description
>> -Eina is a data type library.
>> +Eina is a core data structure and common utility library.
>>
>>   %package -n %libname
>>   Summary: Libraries for the %{name} package
>> @@ -32,10 +46,17 @@
>>   %{name} development headers and libraries.
>>
>>   %prep
>> -%setup -qn %{name}-%{version}
>> +%if %svn
>> +%setup -qn %name
>> +%else
>> +%setup -qn %name-%version
>> +%endif
>>
>>   %build
>> -%configure2_5x
>> +%if %svn
>> +NOCONFIGURE=1 ./autogen.sh
>> +%endif
>> +%configure2_5x --disable-static
>>   %make
>>
>>   %install
>> @@ -44,18 +65,13 @@
>>
>>   find %buildroot -name *.la | xargs rm
"find %buildroot -name *.a | xargs rm" should be also
added as a safeguard as you removed those from %files list, no?
>> -%clean
>> -rm -fr %buildroot
>> -
>>   %files -n %libname
>> -%defattr(-,root,root)
>> +%doc AUTHORS README
>>   %{_libdir}/*.so.%{major}*
>>
>>   %files -n %libnamedev
>> -%defattr(-,root,root)
>>   %{_libdir}/pkgconfig/*
>>   %{_libdir}/*.so
>> -%{_libdir}/*.a
^^ see above
>>   %{_includedir}/*
>>
>>
>> This version is better ?
>> I can commit ?
Apart from the above, looks good.
>> regards,
>> trem
> for me this seems OK
>
Furthermore from this i'm planning to import entrance,
enlightenment login manager for a more complete e experience.
Also maybe (after a little update) my e17-artwork package.

BTW: You already mentioned that you're planning to work on e17
packages, do you want to maintain those that are already there?
And if you update some other e packages could you please tell me
afterwards so i can take a peek, would be really nice :)