[Mageia-dev] mgarepo log regression?

[Anssi Hannula]

On 15.02.2012 18:38, Anssi Hannula wrote:
> On 14.02.2012 22:44, Jani Välimaa wrote:
>> 2012/2/14 barjac <buildsystem-daemon at mageia.org>:
>>> Name        : c++-gtk-utils                Relocations: (not relocatable)
>>> Version     : 2.0.4                             Vendor: Mageia.Org
>>> Release     : 1.mga2                        Build Date: Tue Feb 14 19:36:12 2012
>>> Install Date: (not installed)               Build Host: ecosse.mageia.org
>>> Group       : System/Libraries              Source RPM: (none)
>>> Size        : 2000191                          License: GPLv2
>>> Signature   : (none)
>>> Packager    : barjac <barjac>
>>> URL         : http://cxx-gtk-utils.sourceforge.net
>>> Summary     : GTK+-based ISO image editor
>>> Description :
>>> c++-gtk-utils is a lightweight library containing
>>> a number of classes and functions for programming
>>> GTK+ programs using C++ in POSIX (Unix-like) environments,
>>> where the user does not want to use a full-on wrapper such
>>> as gtkmm or wxWidgets, or is concerned about exception safety
>>> or thread safety of the wrapper and their documentation.
>>> It is parallel installable for both GTK+2 and GTK+3.
>>>
>>> barjac <barjac> 2.0.4-1.mga2:
>>> + Revision: 208908
>>> - &.mga2- del *.a
>>> - imported package c++-gtk-utils
>>
>> You should avoid using macros in commit msgs or at least escape them
>> (%mkrel -> %%mkrel) or use mgarepo to commit changes which does it
>> automatically.
>>
>> Commit msgs "%mkrel & spelling error" and "del *.a" looks now in
>> changelog like "- &.mga2- del *.a".
> 
> Err no, this is an mgarepo regression. It should automatically escape
> the logs when it fetches the log from SVN, and double-checking confirms
> that mdv repsys does it correctly.
> 
> Or has this been intentionally changed at some point??

Actually, scratch that. There is just a bug that escaping isn't done
correctly when '%' is the first character of an SVN log message line.

MgaRepo/log.py:
unescaped_macro_pat = re.compile(r"([^%])%([^%])")

This matches "x%foo", but doesn't match "%foo".

-- 
Anssi Hannula