[Mageia-dev] [packages-commits] [189967] - version upgrade

[Matteo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Il 03/01/2012 17:30, Guillaume Rousse ha scritto:
> Le 03/01/2012 17:18, Jani Välimaa a écrit :
>>> @@ -11,7 +11,7 @@
>>>   Group:        System/Kernel and hardware
>>>   BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot
>>>   URL:        http://www.codemonkey.org.uk/projects/x86info/
>>> -Source0:    %{name}-%{realver}%{?cvsdate:-%{cvsdate}}.tar.bz2
>>> +Source0:    %{name}-%{realver}%{?cvsdate:-%{cvsdate}}.tgz
>>>   Patch0:        x86info-1.17-intel-flags.patch
>>>   Patch1:        x86info-1.17-intel-caches.patch
>>>   Patch2:        x86info-1.17-cpuid-with-ecx-input.patch
>>> @@ -33,17 +33,18 @@
>>>   %setup -q -n %{name}-%{realver}
>>>
>>>   %build
>>> -make CFLAGS="%{optflags}"
>>> +#make CFLAGS="%{optflags}"
>>> +%make
>>>
>>>   %install
>>> -rm -rf %{buildroot}
>>> -install -d %{buildroot}%{_bindir}
>>> -install -d %{buildroot}%{_mandir}/man1
>>> -install -m755 %{name} %{buildroot}%{_bindir}/
>>> -install -m755 %{name}.1 %{buildroot}%{_mandir}/man1/
>>> +%__rm -rf %{buildroot}
>>> +%__install -d %{buildroot}%{_bindir}
>>> +%__install -d %{buildroot}%{_mandir}/man1
>>> +%__install -m755 %{name} %{buildroot}%{_bindir}/
>>> +%__install -m755 %{name}.1 %{buildroot}%{_mandir}/man1/
>>>
>>
>> I think this is pretty much opposite what everyone else is doing. IMHO
>> this also makes .spec harder to read.
> Morevoer, it mixes pure cosmetics changes, as some of those macros just
> expand to the command itself, as install vs %__install,
Hi Guillaume,
I'm sorry, but I don't think that /usr/bin/install it's equal to
'install'. There are technical reasons to avoid these macros? Can you
suggest me some reference, please? I'm not able to find nothing about
this topic.

 with behaviour
> changes, as other macros expand to the command with additional
> arguments, as make vs %make, which is actually make -j.
> 
So if I need to invoke make -j what should I do?
Again, excuse me -I'm not so skilled- but why should I avoid to call
make using -j option?

Be patient, please :-)
- -- 
Matteo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mageia - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPBfuoAAoJED3LowjDDWbNZFIH/jDp/mS0Cw3yFIFHuOnBJ70y
tVw5z+D8DUf0SSOaXU5htnob9zXEg5fyl+adEcDb3s7XLl4Y/Bw5ER38YwHO4Kad
e5n/UnDCIuaWZeSkaRegMJRtu8mjCvnz4303M6VQbS/bopgbFZ5oTmVS5jM0YIEK
Qw35ACjrelcZSQy49HyDehbIT9g4jEvLSM+q7nEIF5EosQ1o+pnu/K6FtnCtD64V
bkUQcnvBoGTibqeD1dhI8dp7DPLEuc1GsZikxPctpSMmojwwZQP5lNyodkko3eyh
iQ3GAT/JSUZB2D8ysYSUgJUFR9hcgFtaETg5byo8vhUQFN9tgYRUzr4kjrO2v6I=
=NhEx
-----END PGP SIGNATURE-----