[Mageia-dev] [soft-commits] [4584] (systemd_unit_exists) factorize

[Thierry Vignaud]

On 23 May 2012 20:38, Colin Guthrie <mageia at colin.guthr.ie> wrote:
>> BTW Colin your test is redundant. -e returns true for symlinks too
>> (unless target doesn't exist in which case we don't care much anyway...)
>
> NAK. No it's not redundant it's very important. The symlinks *will* be
> broken when run via the installer due to the $::prefix as they will
> point to "non-existent" paths in /lib/systemd/ (not to
> /mnt/lib/systemd...) so I treat any symlink that exists (even if it
> points to an invalid unit) as "valid" here.

humm indeed.

> I think I even said as much in a comment or the commit log that it's
> important :)

Then I think it deserves a comment in the code too :-)