[Mageia-dev] [soft-commits] [5837] mount /dev/shm as --bind like other mount points (mga#7329)

[Thierry Vignaud]

On 14 September 2012 17:46, Pascal Terjan <pterjan at gmail.com> wrote:
> I would prefer a different tmpfs to not interfere with stuff outside the chroot

I agree but this needs sudo config and people were complaining about it.

> On Wed, Sep 12, 2012 at 10:35 AM,  <root at mageia.org> wrote:
>> Revision 5837 Author tv Date 2012-09-12 19:35:55 +0200 (Wed, 12 Sep 2012)
>>
>> Log Message
>>
>> mount /dev/shm as --bind like other mount points (mga#7329)
>>
>> else it can result in sudo asking password
>>
>> Modified Paths
>>
>> build_system/iurt/trunk/NEWS
>> build_system/iurt/trunk/lib/Iurt/Chroot.pm
>>
>> Modified: build_system/iurt/trunk/NEWS
>> ===================================================================
>> --- build_system/iurt/trunk/NEWS      2012-09-12 17:35:50 UTC (rev 5836)
>> +++ build_system/iurt/trunk/NEWS      2012-09-12 17:35:55 UTC (rev 5837)
>> @@ -1,4 +1,5 @@
>>  0.6.11 (unreleased)
>> +- mount /dev/shm as --bind like other mount points (mga#7329)
>>
>>  0.6.10
>>  - fix false positive when looking for errors
>>
>> Modified: build_system/iurt/trunk/lib/Iurt/Chroot.pm
>> ===================================================================
>> --- build_system/iurt/trunk/lib/Iurt/Chroot.pm        2012-09-12 17:35:50 UTC (rev
>> 5836)
>> +++ build_system/iurt/trunk/lib/Iurt/Chroot.pm        2012-09-12 17:35:55 UTC (rev
>> 5837)
>> @@ -88,7 +88,7 @@
>>       sudo($config, "--umount", "$chroot/proc");
>>       return;
>>      }
>> -    if (system("$sudo mount none -t tmpfs $chroot/dev/shm")) {
>> +    if (!sudo($config, '--bindmount', "/dev/shm", "$chroot/dev/shm")) {
>>       plog('WARNING', "Failed to mount /dev/shm");
>>      }
>>      if ($run->{icecream}) {
>>