[Mageia-dev] Freeze push: desktop-common-data

[nicolas vigier]

On Sat, 02 Mar 2013, David Walser wrote:

> nicolas vigier wrote:
> > On Sat, 02 Mar 2013, David Walser wrote:
> > 
> >> nicolas vigier wrote:
> >> > Please push desktop-common-data.
> >> > 
> >> > In this new version /usr/bin/editor has been changed to try to use
> >> > $VISUAL and $EDITOR instead of only $TEXTEDITOR :
> >> > http://svnweb.mageia.org/soft/desktop-common-data/trunk/bin/editor?view=log
> >> 
> >> This was a bad change.  It was working fine :o(
> >> 
> >> http://svnweb.mageia.org/soft/desktop-common-data/trunk/bin/editor?r1=7450&r2=7451
> > 
> > It was not working. You can try with a script like this to check that it
> > doesn't work :
> >   #!/bin/sh
> >   TEXTEDITOR="xvt -e vim"
> >   $TEXTEDITOR $@
> > 
> > It opens a new terminal with vim inside, but does not open the file.
> > 
> > Also opening a new terminal when you are already in a terminal is not
> > very nice.
> 
> It was working fine, I tested it when I wrote it.  Do you even know what this script is for?

It doesn't work, and it's easy to see why it cannot work.

A lot of script coming from Debian use /usr/bin/editor and expect it to
open an editor in the same terminal. If you need a script that always
open a graphical editor and does not open the file that is given on
command line you should probably give it an other name.