[Mageia-i18n] String changes in perl-install

[Ahmad Samir]

2011/4/4 Rémi Verschelde <rverschelde at gmail.com>:
> 2011/4/4 Ahmad Samir <ahmadsamir3891 at gmail.com>:
>> Looking at drakx/trunk/perl-install/share/po/libDrakX.pot , I modified
>> some strings in the various .pm files in perl-install to make them
>> read better English (as best I could), since the changes[1] are a lot, I
>> thought I'd better get other people to look at them before committing.
>>
>> [1] http://ryu.zarb.org/~ahmad/perl-install-svn-diff.diff
>>
>> --
>> Ahmad Samir
>>
>
> It looks okay, except for a few ones (I checked only this modified
> strings, though) :
>
>
> Index: mygtk2.pm
> ===================================================================
> --- mygtk2.pm   (revision 805)
> +++ mygtk2.pm   (working copy)
> @@ -1540,7 +1540,7 @@
>     my %weakness_tooltip = (
>         1 => N("Password is trivial to guess"),
>         2 => N("Password is trivial to guess"),
> -        3 => N("Password should resist to basic attacks"),
> +       3 => N("Password should resistant to basic attacks"),
>         4 => N("Password seems secure"),
>         5 => N("Password seems secure"));
>     my $weakness_tooltip = $weakness_tooltip{$password_weakness} ||
> return undef;
> Index: raid.pm
>
> "Password should resistant" means nothing, so it should be either the
> former sentence or "Password should be resistant".
>

Yep, already said so to Thierry (I forwarded the email to him).

>
> Index: fs/mount_options.pm
> ===================================================================
> --- fs/mount_options.pm (revision 804)
> +++ fs/mount_options.pm (working copy)
> @@ -109,38 +109,38 @@
> [...]
> -       'users' => N("Allow every user to mount and umount the file
> system."),
> +       'users' => N("Allow every user to mount and umount the filesystem."),
>
> Just to make sure: does "umount" refer to the command and is used
> abusively as a verb meaning "to unmount", or is it a typo? Both
> "umount" and "unmount" are correct depending on the context, whether
> you want to speak about the commands which the user can use or the
> actions he can perform.

But I didn't change that part it was umount originally :) (will change
it anyway).

>
> [...]
> @@ -203,7 +203,7 @@
>        #- noatime on laptops (do not wake up the hd)
>        #- otherwise relatime (wake up the hd less often / better performances)
>        #- Do  not  update  inode  access times on this
> -       #- file system (e.g, for faster access  on  the
> +       #- filesystem (e.g, for faster access  on  the
>        #- news spool to speed up news servers).
>
> Too many spaces, no ? In the third and fourth (corrected) sentences.

Again I didn't touch that part, and the double spaces are in comments,
so they don't matter.

>
>
> Index: fs/partitioning_wizard.pm
> ===================================================================
> --- fs/partitioning_wizard.pm   (revision 805)
> +++ fs/partitioning_wizard.pm   (working copy)
> @@ -51,7 +51,7 @@
> [...]
> -Your Microsoft Windows® partition will be now resized.
> +Your Microsoft Windows® partition will be resized now.
>
> I'd say "Your Microsoft Windows® partition will now be resized.", but
> the sentence you proposed is okay.
>
> [...]
> -                          $in->ask_from(N("Partitionning"), N("Which
> size do you want to keep for Microsoft Windows® on partition %s?",
> partition_table::description($part)), [
> +                          $in->ask_from(N("Partitionning"), N("What
> size do you want to keep for Microsoft Windows® on partition %s?",
> partition_table::description($part)), [
>
> The new sentence is okay, but maybe this one would be clearer: "Which
> disk space do you want to keep for Microsoft Windows® on partition
> %s?"
>

"Which" implies defined choices, i.e. "Which size do you want to keep for foo?
1) 500
2) 1000
3) 2000 "

if there're no given/defined choices, I think "what" is better in the context.

>
> Index: fsedit.pm
> ===================================================================
> --- fsedit.pm   (revision 805)
> +++ fsedit.pm   (working copy)
>
> [...]
>            cdie N("You've selected a software RAID partition as root (/).
> -No bootloader is able to handle this without a /boot partition.
> -Please be sure to add a /boot partition");
> +No bootloader is able to handle this without a separate separate
> /boot partition.
> +Please be sure to add a separate /boot partition");
>
> You wrote "separate" twice in the first corrected sentence.
>

Yeah, too eager correction, will fix.

> [...]
>  The bootloader is not able to handle this when the volume spans
> physical volumes.
> -You should create a /boot partition first") if $mntpoint eq "/" &&
> isLVM($part) && lvm::lv_nb_pvs($part) != 1 &&
> !fs::get::has_mntpoint("/boot", $all_hds);
> +You should create a /boot separate partition first") if $mntpoint eq
> "/" && isLVM($part) && lvm::lv_nb_pvs($part) != 1 &&
> !fs::get::has_mntpoint("/boot", $all_hds);
>
> You used "separate /boot partition" in all the other modifications, so
> why not here? (moreover "/boot separate partition" sounds bizarre).
>

Typo, will fix.

Thanks :)

>
> Cheers,
> Rémi / Akien
>


-- 
Ahmad Samir