[Mageia-sysadm] [263] PNG is a binary file

[Michael Scherer]

Le lundi 10 janvier 2011 à 20:22 +0200, Thomas Backlund a écrit :
> Maarten Vanraes skrev 10.1.2011 20:16:
> > Op maandag 10 januari 2011 13:41:12 schreef root at mageia.org:
> >> Revision: 263
> >> Author:   pterjan
> >> Date:     2011-01-10 13:41:12 +0100 (Mon, 10 Jan 2011)
> >> Log Message:
> >> -----------
> >> PNG is a binary file
> >>
> >> Modified Paths:
> >> --------------
> >>      build_system/mgarepo/trunk/RepSys/binrepo.py
> >>
> >> Modified: build_system/mgarepo/trunk/RepSys/binrepo.py
> >> ===================================================================
> >> --- build_system/mgarepo/trunk/RepSys/binrepo.py	2011-01-10 12:12:58 UTC
> >> (rev 262) +++ build_system/mgarepo/trunk/RepSys/binrepo.py	2011-01-10
> >> 12:41:12 UTC (rev 263) @@ -106,7 +106,7 @@
> >>   def is_binary(path):
> >>       raw = config.get("binrepo", "upload-match",
> >>               "\.(7z|Z|bin|bz2|cpio|db|deb|egg|gem|gz|jar|jisp|lzma|"\
> >> -               "pdf|pgn\\.gz|pk3|rpm|rpm|run|sdz|smzip|tar|tbz|"\
> >> +               "pdf|pgn\\.gz|pk3|png|rpm|run|sdz|smzip|tar|tbz|"\
> >>                  "tbz2|tgz|ttf|uqm|wad|war|xar|xpi|xz|zip|wav|mp3|ogg|"\
> >>   	       "jpg|png|gif|avi|mpg|mpeg|rar)$")
> >>       maxsize = config.getint("binrepo", "upload-match-size", "1048576") #
> >> 1MiB
> >
> >
> > why is png here twice? (once next to jpg and once next to rpm)
> 
> mistake.
> 
> that list sohuld be kept sorted.


Or use python-magic to get the mime-types and ban everything that do not
match text/*

-- 
Michael Scherer