[Mageia-sysadm] Local changes on mga-youri-submit on valstar

[Pascal Terjan]

On Mon, Jan 28, 2013 at 11:57 AM, nicolas vigier <boklm at mars-attacks.org> wrote:
> Hello,
>
> Before updating mga-youri-submit package on valstar, I checked if we
> have local changes on files from this package.
>
> And we have the following changes which are not on svn, on 2 files :

I don't remember those changes but it may be what made it display the
version when rejected a submit, in which case it needs to be committed
to svn

> --- /usr/share/mga-youri-submit/lib/Youri/Submit/Check/Recency.pm       2012-07-30 17:55:43.629760689 +0200
> +++ usr/share/mga-youri-submit/lib/Youri/Submit/Check/Recency.pm        2013-01-28 12:48:35.911546824 +0100
> @@ -1,4 +1,4 @@
> -# $Id: Recency.pm 224793 2007-07-08 02:44:48Z spuk $
> +# $Id: Recency.pm 3071 2012-02-26 14:45:02Z pterjan $
>  package Youri::Submit::Check::Recency;
>
>  =head1 NAME
> @@ -29,7 +29,7 @@
>          push(
>              @errors,
>              "Current or newer revision(s) already exists in $section for $target: " .
> -                join(', ', map { $_->get_revision } @revisions)
> +                join(', ', @revisions)
>          );
>      }
>
> @@ -49,7 +49,7 @@
>              push(
>                  @errors,
>                  "Current or newer revision(s) already exists in $section for $target: " .
> -                    join(', ', map { $_->get_revision } @revisions)
> +                    join(', ', @default_revisions)
>              );
>          }
>          $define->{section} = $defined_section;
>
> --- /usr/share/mga-youri-submit/bin/youri-submit        2012-07-30 18:02:31.681362361 +0200
> +++ usr/share/mga-youri-submit/bin/youri-submit 2013-01-28 12:48:35.911546824 +0100
> @@ -337,7 +337,7 @@
>                     $target,
>                     $config->get_arg('define')
>                 );
> -               push(@{$errors{$package->get_name ."-" . $package->get_revision}}, @errors) if $errors[0];
> +               push(@{$errors{$package}}, @errors) if $errors[0];
>             }
>         }
>      }
>
>
> Should we keep those changes ?
>
> _______________________________________________
> Mageia-sysadm mailing list
> Mageia-sysadm at mageia.org
> https://www.mageia.org/mailman/listinfo/mageia-sysadm