[Mageia-dev] Importing RPM Spec File Syntax

[Michael Scherer]

Le samedi 15 janvier 2011 à 11:08 +0100, Remy CLOUARD a écrit :

> Patches must be named in a very explicit manner to make it very clear to
> what version it was originally applied. To that end, a patch needs to
> follow the convention of
> [package_name]-[version]-[description].patch:
> 
>   * [package_name] is the name of the package it applies against, such
>   as 'shadow-utils' or 'gnupg'
>   * [version] is the version of the program this patch was developed
>   against, such as 1.0. The name of the patch should not change, even
>   when it is rediffed, because the version allow to see in a blink since
>   when this patch has been there. If you happen to see a patch that does
>   not apply anymore, and rediff it, ask the package maintainer if it has
>   been sent upstream, and why it hasn’t been merged, and send it
>   upstream if you think it should be merged.
>   * [description] is a short description of the patch's purpose.

I would rather use comments for that :

1) saying the patch was sent upstream, with url , or date of sending the
mail ( possibily who )

2) if not sent upstream, say clearly "not upstreamable because foo"

3) if coming from upstream, link to the commit upstream

And for people who want to sent upstream patch, iptutils is full of
patch to comment ( and so are lots of packages ).
-- 
Michael Scherer