[Mageia-dev] Strange warning when building ascii

[Kamil Rytarowski]

On 30.10.2011 08:54, Anssi Hannula wrote:
> On 30.10.2011 00:07, Oliver Burger wrote:
>> Hi,
>>
>> I (or better one of my padawans) have one problem:
>> When trying to build ascii the build is running fine but in the buildlogs,
>> there is a strange warning about not finding any "build ID note".
> This happens when our %ldflags are not used for linking.
>
> You probably need to use LDFLAGS="%ldflags" somewhere or some other flag
> or variable, to get the %ldflags to appear after 'cc' in this line in
> the build:
> cc -DREVISION=3.11 ascii.c -o ascii
>
> - Spoilers below -
>
> OK, looked at the package.
> First, your %build is wrong. You use CFLAGS="$RPM_OPT_FLAGS" in the
> %make command, but the Makefile doesn't even use any CFLAGS variable!
>
> Similarly, it doesn't use LDFLAGS so setting that would do no good either.
>
> You need to either e.g.
> a) change the CFLAGS="$RPM_OPT_FLAGS" to CC="gcc %optflags %ldflags", or
> b) patch the Makefile to use $(CFLAGS) $(LDFLAGS) after the $(CC)
> instance and use %setup_compile_flags before %make.
Thank you! You are amazing!