[Mageia-dev] [packages-commits] [189967] - version upgrade

[Matteo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Il 03/01/2012 17:18, Jani Välimaa ha scritto:
> 2012/1/3  <root at mageia.org>:
>> Revision 189967 Author matteo Date 2012-01-03 16:46:56 +0100 (Tue, 03 Jan
>> 2012)
>>
>> Log Message
>>
>> - version upgrade
>> - used macros instead of command names
>>
>> Modified Paths
>>
>> cauldron/x86info/current/SPECS/x86info.spec
>>
>> Modified: cauldron/x86info/current/SPECS/x86info.spec
>> ===================================================================
>> --- cauldron/x86info/current/SPECS/x86info.spec	2012-01-03 15:45:07 UTC (rev
>> 189966)
>> +++ cauldron/x86info/current/SPECS/x86info.spec	2012-01-03 15:46:56 UTC (rev
>> 189967)
>> @@ -1,5 +1,5 @@
>>  %define	name	x86info
>> -%define	version	1.29
>> +%define	version	1.30
>>  %define realver	%{version}
>>  #define cvsdate	20050420
>>
>> @@ -11,7 +11,7 @@
>>  Group:		System/Kernel and hardware
>>  BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot
>>  URL:		http://www.codemonkey.org.uk/projects/x86info/
>> -Source0:	%{name}-%{realver}%{?cvsdate:-%{cvsdate}}.tar.bz2
>> +Source0:	%{name}-%{realver}%{?cvsdate:-%{cvsdate}}.tgz
>>  Patch0:		x86info-1.17-intel-flags.patch
>>  Patch1:		x86info-1.17-intel-caches.patch
>>  Patch2:		x86info-1.17-cpuid-with-ecx-input.patch
>> @@ -33,17 +33,18 @@
>>  %setup -q -n %{name}-%{realver}
>>
>>  %build
>> -make CFLAGS="%{optflags}"
>> +#make CFLAGS="%{optflags}"
>> +%make
>>
>>  %install
>> -rm -rf %{buildroot}
>> -install -d %{buildroot}%{_bindir}
>> -install -d %{buildroot}%{_mandir}/man1
>> -install -m755 %{name} %{buildroot}%{_bindir}/
>> -install -m755 %{name}.1 %{buildroot}%{_mandir}/man1/
>> +%__rm -rf %{buildroot}
>> +%__install -d %{buildroot}%{_bindir}
>> +%__install -d %{buildroot}%{_mandir}/man1
>> +%__install -m755 %{name} %{buildroot}%{_bindir}/
>> +%__install -m755 %{name}.1 %{buildroot}%{_mandir}/man1/
>>
> 
> I think this is pretty much opposite what everyone else is doing. IMHO
> this also makes .spec harder to read.
Hi Jani,
I'm not able to find references on our wiki that say macros (like
%__install or %__rm) are deprecated, can You point me in the right
direction, please?

IMHO the spec file is as readable as the others.
Regards,
- -- 
Matteo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mageia - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPBfa/AAoJED3LowjDDWbNTCkH+QF1KleqJc1qU5qyjE7X4dtM
FL7iC3OAN93yvVYp57ABHKy9RTF87vbcg6TcRn47BrL4kk8kTUvRftSW94kOIfAJ
Mp7bINrX7UjKPIS4VMvKW56yUN4JMPMcJ9f7pNIE25tnwBzg+Ov0A9MiqVMEZqQE
28GSbl63OFnBag0bDsLKd8POveH91N7FivKcQ5KKwGXm/kw60dlHqn0EH06DSMkV
jTrLU6j4iUvuPitcm22kBtYPsppTyuKmisGrGwCUoJu2sLMZon0zOTbq0GJnSqDb
EhV6w7NiW6ZQeM1+Zvc9IsftzCrJgoWsrTRvabH8B5CPQHb1AcDdid3oSW7SU3Y=
=Zrqs
-----END PGP SIGNATURE-----